[pmwiki-users] new default skin

[H. Fox]

On 8/10/05, Patrick R. Michaud <pmichaud at pobox.com> wrote:
> On Wed, Aug 10, 2005 at 03:11:45PM -0400, Neil Herber wrote:
> > I just noticed that the page titles are selflinks with no indication that
> > they are links. Why do they need to be links at all?
> 
> They don't, and now they aren't.

IMHO it's a good idea to avoid self-referring links.

I don't even like linking the logo to the home page from the home page.

Same goes for the group link when you're already at Group.Group or
Group.HomePage.

In skin.php, this works for the former

    if (empty($pagename) || $pagename==$DefaultPage) {
    [...]

and this for the latter

    $page_array = explode('.',$pagename);
    if (empty($pagename)
      || $pagename == $DefaultPage
      || $page_array['0'] == $page_array['1']
      || $page_array['1'] == 'HomePage')
    {
    [...]

although there are probably better ways to do it.

Hagan