[pmwiki-users] Guiedit buttons issue with 2.3.16
Johan Bengtsson
elijah at chalmers.se
Mon Dec 12 04:57:42 PST 2022
On Mon, 12 Dec 2022, Petko Yotov wrote:
> The guidedit.js file served seems to be an older version, not the one
> from 2.3.16.
OK, maybe it is loading the wrong files. I set FarmPubDirUrl and it seems to
work with the new files, I have to investigate what files are loaded for
non-test wikis..
-Johan
>
> Petko
>
> On 12/12/2022 13:00, Johan Bengtsson wrote:
>> On Mon, 12 Dec 2022, Petko Yotov wrote:
>>
>>> There may be a bug - I will be very interested in identifying it and
>>> fixing it.
>>>
>>> The edit buttons functions were rewritten to move all inline
>>> JavaScript adding individual buttons to the external script. This
>>> allows administrators to enable more strict content-security policies.
>>>
>>> Since the buttons work on a standard wiki (pmwiki.org, and others), it
>>> is possible that some custom buttons need to be reviewed and updated.
>>> In some cases you may need to remove extra backslashes that were in
>>> your $GUIButtons definitions but would not be inserted in the
>>> textarea.
>>>
>>> If you are using a custom edit form, it may need to be updated, or
>>> guiedit.js may need to be fixed.
>>>
>>> Can you restore the 2.3.16 files and provide me with a link, for
>>> example to WikiSandbox?action=edit, so that I can test it myself? (You
>>> can send it to me privately if you want. Preferably also set
>>> $EnableDiag=1; for me.)
>>
>> Here you got it:
>>
>> https://wiki.portal.chalmers.se/italab/Main/WikiSandbox?action=edit
>>
>> $EnableDiag=1; is activated.
>>
>> Best regards,
>> Johan Bengtsson
>>
>>
>>
>>>
>>> Or, you can enable a small set of buttons, try if they work. Then
>>> progressively add new ones and try, and see if it will break at some
>>> point.
>>>
>>> Petko
>>>
>>> On 12/12/2022 10:04, Johan Bengtsson wrote:
>>>> I upgraded a wiki farm from 2.3.2 to 2.3.16, it seems to work well
>>>> except for the gui button row which is not visible at all. I replace
>>>> guiedit.js & guiedit.php with the ones from 2.3.2 and now these
>>>> buttons are working.
>>>>
>>>> But it seems there is a bug here?
>>>
>>> _______________________________________________
>>> pmwiki-users mailing list
>>> pmwiki-users at pmichaud.com
>>> http://www.pmichaud.com/mailman/listinfo/pmwiki-users
>>>
>>
>> ----
>> Systemadministratör - Chalmers IT-avdelning
>> Tel: 6734 https://www.chalmers.se/it
>
> _______________________________________________
> pmwiki-users mailing list
> pmwiki-users at pmichaud.com
> http://www.pmichaud.com/mailman/listinfo/pmwiki-users
>
----
Systemadministratör - Chalmers IT-avdelning
Tel: 6734 https://www.chalmers.se/it
More information about the pmwiki-users
mailing list