<div class="gmail_quote">On Tue, May 26, 2009 at 8:53 PM, Patrick R. Michaud <span dir="ltr"><<a href="mailto:pmichaud@pobox.com">pmichaud@pobox.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I'm willing to entertain patches that make it possible to view page<br>
text variables when a page is being previewed, but the fact that<br>
it doesn't work now isn't exactly a bug in my book.<br>
<font color="#888888"></font></blockquote><div><br>It seems like the only "sure-fire" way to deal with any and all issues related to preview processing would be to patch the pagestore Read() function. However, this is going to cause a performance hit throughout all operations and seems very not worth it.<br>
<br>However, to fix the specific issue raised by Randy it could suffice to patch PreviewPage(), adding these:<br><br> PCache($pagename, $new);<br> CachePTV($pagename, $new);<br><br>Then CachePTV() needs to be defined by splitting up PageTextVar() so that PageTextVar() reads the page, calls CachePTV() with the $page read, and then returns from the cached values. CachePTV() itself would be the code from PageTextVar() which processes the $page and caches.<br>
<br>I'm happy to code up a patch if it's likely to be used in core, but it doesn't lend itself to a recipe and so is pointless unless it will be included...<br><br>-Peter<br></div></div>