<div class="gmail_quote">2010/1/12 Patrick R. Michaud <span dir="ltr"><<a href="mailto:pmichaud@pobox.com">pmichaud@pobox.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Mon, Jan 11, 2010 at 09:22:19PM +1300, Simon wrote:<br>
> I'd like to solicit votes for <a href="http://www.pmwiki.org/wiki/PITS/00638" target="_blank">http://www.pmwiki.org/wiki/PITS/00638</a><br>
><br>
> Description: To facilititate customistion using CSS could the table tag<br>
> generated for simple tables markup please have a class added to it. eg<br>
><br>
> <table class="wikisimpletable"<br>
<br>
</div>On PITS:00638, you added the comment:<br>
<br>
... This would simply be a default class added in addition to any a user<br>
declares in a class= parameter. ...<br>
<br>
The problem is that this isn't actually "simple" nor "straightforward".<br>
PmWiki doesn't have an easy way to put a default class "in addition to<br>
any a user declares" -- as things currently exist it can either use a<br>
hard-coded one, fall back to a default, or accept the class declaration<br>
provided by the user. There's not a simple mechanism for combining classes<br>
(which, btw, I personally find to be a serious flaw in the design of CSS itself).<br>
<br>
So, add "a default class in addition to a user-declared class" would<br>
actually require substantial code changes to the simple table markup.<br>
It also would remove the ability for users to create a simple table<br>
without having the default class in it. So, what you're describing<br>
is not at all a trivial change, and does impact existing wikis.<br>
<br>
It's entirely possible for a wiki administrator to set a default<br>
class explicitly in config.php (the PITS comments incorrectly omit<br>
the required [0] subscript):<br>
<br>
$BlockMarkups['table'][0] = "<table class='wikisimpletable' width='100%'>";<br>
<br>
This sets the default class for any simple tables that get generated,<br>
although it can be overridden by any user-supplied class. It only affect<br>
simple tables -- it doesn't change the class settings for advanced tables<br>
or other tables that PmWiki generates.<br>
<br>
Having looked at it a bit further, I don't have a big problem with<br>
the above $BlockMarkup value being set as the default in stdmarkup.php,<br>
as long as we're clear that any user-supplied class= attribute continues<br>
to override the default class attribute, and is not in addition<br>
to it.<br>
<font color="#888888"><br>
Pm<br>
</font></blockquote></div><br>I would be very happy with this.
<div>Thanks</div><div>Simon</div>