<div dir="ltr"><div class="gmail_default" style="font-size:small">Thank you Petko! Your "possible fix" seems to work (although $url was on lines 75 & 83 for me). This is just another reason to love pmwiki - it's actually SUPPORTED! Thanks again.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">So who is responsible for fixing/updating the current includeurl.php file on the site?</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Byron</div><div class="gmail_default" style="font-size:small"><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 15, 2016 at 10:41 PM, Petko Yotov <span dir="ltr"><<a href="mailto:5ko@5ko.fr" target="_blank">5ko@5ko.fr</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Indeed, I confirm that the documented way to include URLs on the same server doesn't work:<br>
<br>
(:includeurl /samplesite/path/page.html :)<br>
<br>
The reason is that the target URL is processed by the MakeLink function in order to test if the external link is approved.<br>
<br>
But if it is not an external link (http, https, ftp...) this function assumes it is an internal page link, and having more than one among "/" and "." would be an invalid page name, so it returns an empty string.<br>
<br>
With the current includeurl.php, the loading of local resources is broken. You can use the full URLs.<br>
<br>
A possible fix would be to replace "$url" with "$tgt" on lines 80 and 88.<br>
<br>
Petko<br>
<br>
---<br>
Change log : <a href="http://www.pmwiki.org/wiki/PmWiki/ChangeLog" rel="noreferrer" target="_blank">http://www.pmwiki.org/wiki/PmW<wbr>iki/ChangeLog</a><br>
Release notes : <a href="http://www.pmwiki.org/wiki/PmWiki/ReleaseNotes" rel="noreferrer" target="_blank">http://www.pmwiki.org/wiki/PmW<wbr>iki/ReleaseNotes</a><br>
If you upgrade : <a href="http://www.pmwiki.org/wiki/PmWiki/Upgrades" rel="noreferrer" target="_blank">http://www.pmwiki.org/wiki/PmW<wbr>iki/Upgrades</a><div class="HOEnZb"><div class="h5"><br>
<br>
<br>
On 2016-08-16 03:51, Byron Lunz wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I upgraded to the latest version 2.2.89 but still see the same problem.<br>
Using the latest includeurl.php file from <a href="http://pmwiki.org" rel="noreferrer" target="_blank">pmwiki.org</a>, I can include only<br>
links which begin with http or https - not links to local files such as<br>
(:includeurl /update/file.php :)<br>
<br>
Should links to files work (they used to), or do I need to edit all my<br>
links to full URLs??<br>
<br>
<br>
On Sun, Aug 14, 2016 at 5:54 PM, Byron Lunz <<a href="mailto:byronlunz@gmail.com" target="_blank">byronlunz@gmail.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Well, I spoke too soon. The new includeurl.php did indeed allow the<br>
included https links to work, but various others which were only pointing<br>
to files (e.g. "includeurl /update/some.php") stopped working.<br>
<br>
On Sun, Aug 14, 2016 at 6:34 AM, Byron Lunz <<a href="mailto:byronlunz@gmail.com" target="_blank">byronlunz@gmail.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi, Petko,<br>
<br>
Thank you! Installing the latest version of includeurl.php did the trick!<br>
<br>
Byron<br>
<br>
<br>
<br>
<br>
On Sat, Aug 13, 2016 at 10:35 PM, Petko Yotov <<a href="mailto:5ko@5ko.fr" target="_blank">5ko@5ko.fr</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Normally browsers will refuse to load resources from the "http" scheme<br>
if the requesting page is on a "https" connection.<br>
<br>
The current version of includeurl.php works fine with a "https" URL. On<br>
your page it does not appear to be the case: even if you have in the source<br>
"https", somehow it becomes "http" in the output.<br>
<br>
Does it work for you with the latest version from here:<br>
<br>
<a href="http://www.pmwiki.org/wiki/Cookbook/IncludeUrl" rel="noreferrer" target="_blank">http://www.pmwiki.org/wiki/Coo<wbr>kbook/IncludeUrl</a><br>
<br>
Petko<br>
<br>
On 2016-08-14 00:22, Byron Lunz wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
My web site is implemented via pmwiki. We just installed a LetsEncrypt<br>
cert<br>
to convert all accesses to https. Now, the forms which would previously<br>
displayed using the includeurl directive no longer appear.<br>
<br>
Chrome's developer console says:<br>
[image: Inline image 1]<br>
... even after I have edited the includeurl from http to https. I've<br>
also<br>
added a line of markup to config.php from the includeurl man page which<br>
is<br>
supposed to allow https but so far no joy.<br>
<br>
Page in question is <a href="https://www.cctomany.com/Info/ContactUs" rel="noreferrer" target="_blank">https://www.cctomany.com/Info/<wbr>ContactUs</a><br>
<br>
</blockquote></blockquote></blockquote></blockquote></blockquote>
<br>
______________________________<wbr>_________________<br>
pmwiki-users mailing list<br>
<a href="mailto:pmwiki-users@pmichaud.com" target="_blank">pmwiki-users@pmichaud.com</a><br>
<a href="http://www.pmichaud.com/mailman/listinfo/pmwiki-users" rel="noreferrer" target="_blank">http://www.pmichaud.com/mailma<wbr>n/listinfo/pmwiki-users</a><br>
</div></div></blockquote></div><br></div>