<div dir="ltr"><div style="font-family:times new roman,serif;font-size:large" class="gmail_default"></div><div dir="ltr"><div class="gmail_default" style="font-family:times new roman,serif;font-size:large">I use abctunebook. I made some mods to cope with php 7.2 and the latest pmwiki-release.</div><div class="gmail_default" style="font-family:times new roman,serif;font-size:large"><br></div><div class="gmail_default" style="font-family:times new roman,serif;font-size:large">Here are my diffs:</div><div class="gmail_default" style="font-family:times new roman,serif;font-size:large"><br></div><div class="gmail_default" style="font-size:large"><span style="font-family:courier new,monospace">--- abctunebook/cookbook/abctunebook.php 2016-01-08 15:39:00.000000000 +0100<br>+++ cookbook/abctunebook.php 2018-11-13 12:43:55.756779161 +0100<br>@@ -16,20 +16,23 @@<br> <br> $RecipeInfo['AbcTunebook']['Version'] = '2016-01-08';<br> <br>-SDV($AbcTunebooks['default'], 'Tunebook');<br>+SDV($AbcTunebooks, array('default'=>'Tunebook', 0 => 'Liederbuch'));<br>+<br>+<br> SDV($AddTunePage, 'NewTune');<br> <br> SDVA($Abcjs, array(<br>- 'dir' => $PubDirUrl.'/abcjs',<br>+ 'dir' => $FarmPubDirUrl.'/abcjs',<br> 'base' => 'abcjs_base-min.js',<br> 'editor' => 'abc_editor.js',<br>+ 'editor' => 'abc_editor.js',<br> 'plugin' => 'abc_plugin.js',<br> 'midi_program' => '1',<br> 'midi_qpm' => '160',<br> ));<br> <br> # (:abcjs:) directive will load abcjs plugin scripts even if page is not in a tunebook group.<br>-Markup_e('abcjs', 'directives', '/\\(:abcjs:\\)/is', "AbcjsLoadPlugin(\$pagename)");<br>+Markup('abcjs', 'directives', '/\\(:abcjs:\\)/is', "AbcjsLoadPlugin");<br> <br> # otherwise abcjs will not be loaded and markup rules not be set<br> $name = PageVar($pagename,'$Name');<br>@@ -37,17 +40,21 @@<br> if (!in_array($group, $AbcTunebooks)) return;<br> <br> # load abcjs plugin<br>-if($action=='browse') {<br>+if($action!='edit') {<br> AbcjsLoadPlugin($pagename);<br>- Markup_e('X:abc', '>[=','/(?<!\\]\\]\n)(X:\\s*\\d+\\s*\n.*?)\n<:vspace>/s',"AbcTextMarkup(\$m[1])");<br>- Markup_e('#abc', '<X:abc',<br>- '/\\[\\[#(abc\\d*)\\]\\](.*?)\\[\\[#\\1end\\]\\]/is', "AbcTextMarkup(\$m[2],\$m[1])");<br>+ Markup('X:abc', '>[=','/(?<!\\]\\]\n)(X:\\s*\\d+\\s*\n.*?)\n<:vspace>/s',"AbcTextMarkup");<br>+ Markup('#abc', '<X:abc',<br>+ '/\\[\\[#(abc\\d*)\\]\\](.*?)\\[\\[#\\1end\\]\\]/is', "AbcTextMarkup2");<br>+}<br>+<br>+function AbcTextMarkup2($m) {<br>+return AbcTextMarkup($m,$m[1]);<br> }<br> <br> $FmtPV['$MidiTempo'] = '$GLOBALS[Abcjs]["midi_qpm"]';<br> <br>-function AbcjsLoadPlugin($pagename) {<br>- global $Abcjs, $AbcTunebooks, $HTMLFooterFmt, $HTMLHeaderFmt, $HTMLStylesFmt;<br>+function AbcjsLoadPlugin($m) {<br>+ global $Abcjs, $AbcTunebooks, $HTMLFooterFmt, $HTMLHeaderFmt, $HTMLStylesFmt, $pagename;<br> $speed = PageTextVar($pagename, 'speed');<br> if (!$speed) $speed = 1;<br> $rhythm = PageTextVar($pagename, 'R');<br>@@ -73,9 +80,9 @@<br> ";<br> }<br> <br>-function AbcTextMarkup($text, $section=false) {<br>+function AbcTextMarkup($m, $section=false) {<br> static $cnt=0; $cnt++;<br>- $text = trim($text);<br>+ $text = trim($m[2]);<br> $out = '';<br> if ($section) {<br> $editlnk = "{[foxedit $section 'edit' form=Site.FoxAbcTemplates#editabc]}";</span></div><div class="gmail_default" style="font-family:times new roman,serif;font-size:large">----------------------------------------------------------------------------------<br></div><div class="gmail_default" style="font-family:times new roman,serif;font-size:large">It seems to work for me, at least partially. I have some difficulties with the inline-editor.</div><div class="gmail_default" style="font-family:times new roman,serif;font-size:large"><br></div><div class="gmail_default" style="font-family:times new roman,serif;font-size:large">Hope this helps,</div><div class="gmail_default" style="font-family:times new roman,serif;font-size:large"><br></div><div class="gmail_default" style="font-family:times new roman,serif;font-size:large">jürgen<br></div><div class="gmail_default" style="font-family:times new roman,serif;font-size:large"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Am Di., 16. Juli 2019 um 04:44 Uhr schrieb David Cooke <<a href="mailto:david@ellendee.co.uk">david@ellendee.co.uk</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u>
<div><p>Is anyone using ABC tunebook and got it working. I used to use this a while ago, I came back last week to rebuild my folk song website only to find that it is now 'broken'. The last update was about 3 years ago with the previous major PHP update. Now when I try to install it, I'm getting loads of error messages and no music script. </p><div class="gmail-m_3982870275926634685io-ox-signature"><p> Regards<br></p><p><br></p><p><b>Dave Cooke</b><br></p></div></div>
_______________________________________________<br>
pmwiki-users mailing list<br>
<a href="mailto:pmwiki-users@pmichaud.com" target="_blank">pmwiki-users@pmichaud.com</a><br>
<a href="http://www.pmichaud.com/mailman/listinfo/pmwiki-users" rel="noreferrer" target="_blank">http://www.pmichaud.com/mailman/listinfo/pmwiki-users</a><br>
</blockquote></div></div>