[pmwiki-users] Tricky issue with approveUrl and included pages

Patrick R. Michaud pmichaud at pobox.com
Sun Dec 11 13:33:40 CST 2005


On Sat, Dec 03, 2005 at 11:10:59AM +0100, chr at home.se wrote:
> What was really happening here was that the external links came from a
> page that was *included* to the main page... so approveUrl naturally never
> even saw these links. I'm not exactly new to pmwiki, but this have had me
> fooled for weeks (partly because it's a new site and I thought it was some
> special bug in my setup due to shared groups and whatnot).
> 
> Anyway, could this situation be improved? For instance, what if approveUrl
> were to look for (:include:) in the page, and if the page does include
> other pages, the script would simply issue a small warning message.  

Looking only for (:include:) might not be enough -- it would still
miss links coming from GroupHeader and GroupFooter, as well as 
other recipes that include contents (e.g., PmCalendar).

> Thinking even further along this line, what if we always got a (temporary)  
> message after performing approveUrl? Perhaps it could look something like
> this:
> 
> 	The following external links were found in the page <page> and
> 	and have now been approved:
> 	* http://...

Personally, I like that I'm instantly returned back to the page with
the links all approved -- this keeps the number of involved clicks to
a minimum (and I think url approval needs to be kept as unintrusive as
possible).  But we could probably make it into an option.

> 	See [[PmWiki.ApproveUrls]] for further details.
> 
> Thoughts?

Perhaps it would be sufficient if the handling of include pages
and approvals was documented somewhere, or placed in a FAQ.

Pm




More information about the pmwiki-users mailing list