[pmwiki-users] Upload problem - interaction with Wikiforms and CSS for form styles

[Patrick R. Michaud]

On Fri, May 26, 2006 at 09:27:58AM +1200, John Rankin wrote:
> On Thursday, 25 May 2006 2:23 AM, Curtis, Clayton <Clayton.Curtis at va.gov> wrote:
> >= = = = =
> ><?php if (!defined('PmWiki')) exit();
> >if (preg_match('/[.\\/]\\d{5}$/',$pagename)) $HTMLStylesFmt['form'] = "
> >#wikitext dt { font-weight: bold; }
> >#wikitext dt:after { content: ':' }
> >#wikitext p { margin-left: 40px; }";
> >?>
> 
> Try the following change:
> 
> if ($action=='browse && preg_match('/[.\\/]\\d{5}$/',$pagename)) $HTMLStylesFmt['form'] = "
> 
> It is not at all obvious to me why a style should cause upload to break, 
> I'm afraid...

I'm with John on this one -- I can't imagine why a style would
cause upload to break here.  However, it might be worthwhile to
add an extra space or newline at the end of the style definition -- as in:

  if (preg_match('/[.\\/]\\d{5}$/',$pagename)) $HTMLStylesFmt['form'] = "
  #wikitext dt { font-weight: bold; }
  #wikitext dt:after { content: ':' }
  #wikitext p { margin-left: 40px; }\n";

(Note the extra space before the closing ").  This is useful to prevent
two successive style definitions from abutting each other in the output,
which might cause problems for the browser.

Beyond that... I don't see why the style affects things.

Pm