[pmwiki-users] blank line at start of html output

[John Rankin]

Could a /e modifier cause this under php 5.5 if the server has warnings 
suppressed?

includeurl.php contains:
Markup('includeurl', 'directives',
   '/\\(:includeurl\\s*(.*?)\\s*:\\)/ei',
   "IncludeUrl(\$pagename, PSS('$1'))");

That could explain why my test system doesn't show an error, since I'm 
not running php 5.5.

We'll try changing it to use Markup_e.

On 28/04/14 2:05 PM, John Rankin wrote:
> One more piece of information: removing the ?> from the end of the 
> backup script makes no difference -- still getting a blank line at the 
> start of the page source.
>
> JR
>
> On 28/04/14 1:52 PM, John Rankin wrote:
>>
>> On 27/04/14 9:51 PM, Petko Yotov wrote:
>>> John Rankin writes:
>>>
>>>>
>>>>
>>>> > John Rankin writes:
>>>> ...
>>>> >> I can see a blank first line in the regular html output too, so 
>>>> it's not
>>>> >> an artefact of wikipublisher's output.
>>>> >>
>>>> >> I am unable to figure out where pmwiki inserts this blank first 
>>>> line and
>>>> >> how to prevent it. Any help would be appreciated.
>>>> >
>>>> > PmWiki doesn't insert a blank first line. Such lines are sometimes
>>>> > inserted
>>>> > by recipe which contain a closing ?> PHP tag followed by a new 
>>>> line. In
>>>> > this
>>>> > case, the backup_pages.php recipe inserts this new line.
>>>> >
>>>> > It is recommended to remove the closing ?> tag from all scripts, 
>>>> see:
>>>> >
>>>> >   http://www.pmwiki.org/wiki/PmWiki/DesignNotes
>>>>
>>>> Ah, thank you.
>>>>
>>>> However, I checked and include url doesn't have a closing ?> tag. I 
>>>> can't
>>>> see what this script is doing that could generate an empty first 
>>>> line. My
>>>> user has tested this with and without includeurl -- on his system, it
>>>> causes an empty first line.
>>>
>>> I didn't write that includeurl causes this, I wrote that 
>>> backup_pages.php causes this.
>> OK, I asked the user to re-test this (cc'd) and he tells me that both 
>> the backup and includeurl scripts independently cause a blank line at 
>> the start of the html and wikibook xml output. However, I have 
>> installed includeurl on a test system and am unable to replicate the 
>> problem.
>>
>> I'm waiting to hear the result of removing the closing ?> from the 
>> backup script, but I'm at a loss as to how to proceed with 
>> includeurl, given that I can't reproduce the behaviour.
>>
>> Any suggestions would be welcome.
>>
>> JR
>>
>