[pmwiki-users] required="required" attributes

Robert Riebisch rr at bttr-software.de
Tue Nov 19 13:07:01 PST 2019


pressing the "Cancel" button in PmWiki version >=2.2.119 at, e.g.,
<https://www.pmwiki.org/wiki/PmWiki/ChangeLog?action=edit> requires to
fill the author field at first to continue.
That doesn't make sense to me.

Generated HTML code should be changed from:
  <input type='submit' name='cancel' value=' Cancel ' />
  <input type='submit' name='cancel' value=' Cancel '
formnovalidate='formnovalidate' />
if "$EnablePostAuthorRequired = 1;".

Please find a proposed patch attached.
1) A similar change worked for me in PmWiki 2.2.120. The patch attached
for 2.2.122 is untested, but should work.
2) Is the comma after 'aria-hidden' in the original file okay? In
2.2.120 there is no comma after the last value.
3) Maybe a similar patch is also required for "EnableUploadAuthorRequired".

              +++ BTTR Software +++
     Home page: https://www.bttr-software.de/
DOS ain't dead: https://www.bttr-software.de/forum/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: forms.php.diff
URL: <http://www.pmichaud.com/pipermail/pmwiki-users/attachments/20191119/ee6c4e70/attachment.ksh>

More information about the pmwiki-users mailing list