[pmwiki-devel] bug in RestorePage()?

Petko Yotov 5ko at 5ko.fr
Sat Apr 11 19:19:36 CDT 2009


On Friday 10 April 2009 20:42:03 Peter Bowers wrote:
> However, it appears that the $page array must be read in with a $since
> of the same value as the $restore value or else RestorePage() doesn't
> work.
>
> Specifically this line in RestorePage() appears to be in error:
>
>     if ($k<$restore) break;
>
> This appears to be trying to compare a timestamp with the desired
> timestamp and not processing any more if we have passed the desired
> timestamp.  However, the key to this hash is actually
> "diff:12341234:23452345" rather than just 12341234.  Thus $k is
> "diff:12341234:23452345" and that is being compared to $restore which
> is "12341234". 

$restore is also something like this: "diff:1234437773:1234437713".

Thanks,
Petko



More information about the pmwiki-devel mailing list